-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Consul module #2194
Added Consul module #2194
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me, thanks for your time contributing the module 👏
Could please remove the examples/consult
directory and all the references to it?:
- dependabot
- ci.yml
- vscode workspace
- mkdocs
- sonar.properties
Once there, I think we can merge it. Thanks!
I noticed there are references to |
Yes please, I can do the toil for you given the case, so feel free to ping me to perform them if needed |
* main: feat (postgres): support for creating and restoring Snapshots (testcontainers#2199) fix: apply volume options only to volumes (testcontainers#2201) redpanda/test: add admin client call (testcontainers#2200) chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197) chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196) fix: go doc reference broken image (testcontainers#2195) Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
* main: chore(ci): do not fail fast main tests in different Go versions (testcontainers#2210)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this new module 🚀
What does this PR do?
This PR adds the Consul module.
modulegen
was used as starting point, on top of which a couple of methods were added.Why is it important?
This module helps integrate testing with Consul which can be useful to verify the correct behavior under different scenarios.
How to test this PR
Tests are included within the module itself.