Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Consul module #2194

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Added Consul module #2194

merged 12 commits into from
Feb 15, 2024

Conversation

Chris-AS1
Copy link
Contributor

What does this PR do?

This PR adds the Consul module. modulegen was used as starting point, on top of which a couple of methods were added.

Why is it important?

This module helps integrate testing with Consul which can be useful to verify the correct behavior under different scenarios.

How to test this PR

Tests are included within the module itself.

@Chris-AS1 Chris-AS1 requested a review from a team as a code owner February 3, 2024 22:01
Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 28a3de6
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65cddd68149f680008f87977
😎 Deploy Preview https://deploy-preview-2194--testcontainers-go.netlify.app/modules/consul
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, thanks for your time contributing the module 👏

Could please remove the examples/consult directory and all the references to it?:

  • dependabot
  • ci.yml
  • vscode workspace
  • mkdocs
  • sonar.properties

Once there, I think we can merge it. Thanks!

modules/consul/examples_test.go Outdated Show resolved Hide resolved
modules/consul/examples_test.go Outdated Show resolved Hide resolved
@mdelapenya mdelapenya self-assigned this Feb 4, 2024
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Feb 4, 2024
@Chris-AS1
Copy link
Contributor Author

Chris-AS1 commented Feb 5, 2024

I noticed there are references to examples/consul inside RELEASING.md too. Want me to remove those?

@mdelapenya
Copy link
Member

I noticed there are references to examples/consul inside RELEASING.md too. Want me to remove those?

Yes please, I can do the toil for you given the case, so feel free to ping me to perform them if needed

RELEASING.md Outdated Show resolved Hide resolved
* main:
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
* main:
  chore(ci): do not fail fast main tests in different Go versions (testcontainers#2210)
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this new module 🚀

@mdelapenya mdelapenya merged commit 50fc8e7 into testcontainers:main Feb 15, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants